Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(checks): add reStructuredText syntax checking #13540

Merged
merged 1 commit into from
Jan 16, 2025
Merged

feat(checks): add reStructuredText syntax checking #13540

merged 1 commit into from
Jan 16, 2025
+261 −18

Conversation

nijel
Copy link
Member

@nijel nijel commented Jan 16, 2025 •
edited
Loading

Proposed changes

Use docutils to parse the string and show discovered errors.

Issue #8446

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@nijel nijel added this to the 5.10 milestone Jan 16, 2025
@nijel nijel self-assigned this Jan 16, 2025
@nijel nijel requested a review from orangesunny as a code owner January 16, 2025 12:19
@nijel nijel force-pushed the rst-syntax branch 6 times, most recently from 163622d to 6a2291f Compare January 16, 2025 14:21
@codecov Codecov
Copy link

codecov bot commented Jan 16, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.64286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.95%. Comparing base (d24f47c) to head (65c2e8e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
weblate/checks/markup.py 92.20% 2 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main   #13540    +/-   ##
========================================
  Coverage   90.95%   90.95%            
========================================
  Files         604      604            
  Lines       62827    62929   +102     
  Branches     6488     6503    +15     
========================================
+ Hits        57142    57238    +96     
- Misses       4000     4002     +2     
- Partials     1685     1689     +4
Files with missing lines Coverage Δ
weblate/checks/base.py 93.17% <100.00%> (+0.27%) ⬆️
weblate/checks/models.py 82.55% <ø> (ø)
weblate/checks/tests/test_markup_checks.py 100.00% <100.00%> (ø)
weblate/checks/markup.py 92.78% <92.20%> (-0.30%) ⬇️

@nijel
feat(checks): add reStructuredText syntax checking
65c2e8e 
Use docutils to parse the string and show discovered errors.

Issue WeblateOrg#8446
@nijel nijel merged commit be16ca8 into WeblateOrg:main Jan 16, 2025
37 of 52 checks passed
@nijel nijel deleted the rst-syntax branch January 16, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orangesunny orangesunny Awaiting requested review from orangesunny orangesunny is a code owner

Assignees

@nijel nijel

Labels
None yet
Projects
None yet
Milestone
5.10
Development

Successfully merging this pull request may close these issues.
1 participant
@nijel